Faris/dwm
1
0
Fork 0
mirror of git://git.suckless.org/dwm synced 2026-03-02 16:25:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

getstate: fix access type and remove redundant cast

Browse Source 
WM_STATE is defined to be format == 32 which xlib returns as
`long` and so accessing it as `unsigned char` is incorrect.

and also &p is already an `unsigned char **` and so the cast was
completely redundant.

given the redundant cast, i assume `p` was `long *` at some time
but was changed to `unsigned char *` later, but the pointer
access (and the cast) wasn't updated.

also add a `format == 32` check as safety measure before
accessing, just in case.
This commit is contained in:
NRK 2026-02-15 22:59:13 +00:00 committed by Hiltjo Posthuma
parent 397d618f1c
commit 5c9f30300b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dwm.c
View File

@ -897,10 +897,10 @@ getstate(Window w)
Atom real; Atom real;
if (XGetWindowProperty(dpy, w, wmatom[WMState], 0L, 2L, False, wmatom[WMState], if (XGetWindowProperty(dpy, w, wmatom[WMState], 0L, 2L, False, wmatom[WMState],
&real, &format, &n, &extra, (unsigned char **)&p) != Success) &real, &format, &n, &extra, &p) != Success)
return -1; return -1;
if (n != 0) if (n != 0 && format == 32)
result = *p; result = *(long *)p;
XFree(p); XFree(p);
return result; return result;
} }